Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Nullable<T> conversions & support #446

Merged

Conversation

Ilia-Kosenkov
Copy link
Member

@Ilia-Kosenkov Ilia-Kosenkov commented Jan 14, 2023

  • Add TryFrom<RObj> and its variations for Nullable<T>
  • Add conversions to and from Options<T>
  • Add map() method that works similar to that of Options<T>, allowing acting on the state while propagating NULL
  • Add a few doctests
  • Add integration test
  • Fix integration tests setup/config, update with newest versions of {rextendr} and {roxygen2}

extendr-api/src/wrapper/nullable.rs Outdated Show resolved Hide resolved
extendr-api/src/wrapper/nullable.rs Outdated Show resolved Hide resolved
extendr-api/src/wrapper/nullable.rs Outdated Show resolved Hide resolved
tests/extendrtests/DESCRIPTION Outdated Show resolved Hide resolved
extendr-api/src/wrapper/nullable.rs Outdated Show resolved Hide resolved
@Ilia-Kosenkov Ilia-Kosenkov marked this pull request as draft January 14, 2023 20:12
@Ilia-Kosenkov Ilia-Kosenkov force-pushed the feature/Improve-nullable-support branch from f50d374 to 04f02c2 Compare January 15, 2023 10:07
@Ilia-Kosenkov Ilia-Kosenkov force-pushed the feature/Improve-nullable-support branch from 04f02c2 to 789f6b8 Compare January 15, 2023 10:14
@Ilia-Kosenkov Ilia-Kosenkov force-pushed the feature/Improve-nullable-support branch from 789f6b8 to 35bb02a Compare January 15, 2023 10:16
@Ilia-Kosenkov Ilia-Kosenkov marked this pull request as ready for review January 16, 2023 18:04
@Ilia-Kosenkov Ilia-Kosenkov merged commit 819f826 into extendr:master Jan 20, 2023
@multimeric
Copy link
Member

Does this PR relate to #313 in any way?

@Ilia-Kosenkov
Copy link
Member Author

Not directly, but maybe it covers some of the cases listed there. The original issue is about Option<T>, which we reserve for NA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants