Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the robj_ndarray module #450

Merged
merged 14 commits into from
Feb 11, 2023
Merged

Document the robj_ndarray module #450

merged 14 commits into from
Feb 11, 2023

Conversation

multimeric
Copy link
Member

@multimeric multimeric commented Jan 17, 2023 •
edited

  • Document the robj_ndarray module
  • Add conversion for owned arrays, with tests

@multimeric
Copy link
Member Author

Two questions for whoever reviews this:

  1. Why is the WIndows build failing? Is that at all relating to my PR?
  2. Why does it seem like the doctests aren't being run for this PR. I've added a number of examples that do run correctly and it would be nice to know that they're being checked.

multimeric and others added 2 commits January 19, 2023 20:50
@multimeric @Ilia-Kosenkov
Explain that array is copied into R
c32cbf7 
Co-authored-by: Ilia Kosenkov <ilia.kosenkov.at.gm@gmail.com>
@multimeric
Clarify that you don't have to return a reference
b8ab4ae
Ilia-Kosenkov
Ilia-Kosenkov approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@Ilia-Kosenkov Ilia-Kosenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, LGTM

@constantingoeldel
Copy link

Thanks for the documentation, this already helped me!

@Ilia-Kosenkov Ilia-Kosenkov added documentation Improvements or additions to documentation feature-ndarray All things ndarray-related labels Feb 3, 2023
@multimeric
Copy link
Member Author

Going to hold off on merging this until we merge #460, so I can rewrite to use rstest.

@multimeric
Copy link
Member Author

Has now been updated to use rstest. Once the CI is running again, this is good to go.

Ilia-Kosenkov
Ilia-Kosenkov requested changes Feb 9, 2023
View reviewed changes
Copy link
Member

@Ilia-Kosenkov Ilia-Kosenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we also mention in the docs that we can handle ArrayView<Rint> and friends?

extendr-api/src/robj_ndarray.rs Outdated Show resolved Hide resolved
@multimeric @Ilia-Kosenkov
Update extendr-api/src/robj_ndarray.rs
74c26c3 
Co-authored-by: Ilia Kosenkov <ilia.kosenkov.at.gm@gmail.com>
@multimeric multimeric merged commit 30d6b8d into extendr:master Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ilia-Kosenkov Ilia-Kosenkov Awaiting requested review from Ilia-Kosenkov

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation feature-ndarray All things ndarray-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@multimeric @constantingoeldel @Ilia-Kosenkov