Use Rf_mkCharLenCE() instead of Rf_mkCharLen() #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to test this explicitly? Perhaps use a non-ASCII string to see how it is handled? |
|
I don't think so. We can test this only on R 4.1, which will retire soon. |
Ilia-Kosenkov
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just happened to find this. This can be a problem only on Windows with R < 4.2 (
Rf_mkCharLen()uses the native encoding), where UTF-8 is not R's default encoding, so this is almost just a nitpicking.For reference, cpp11 also uses
Rf_mkCharLenCE().https://github.com/r-lib/cpp11/blob/c22dc9b611fe7d56ddfc57add2e01b1424869c0f/inst/include/cpp11/r_string.hpp#L19-L20