Add -lntdll and ignore warnings on Windows oldrel #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutannihilation
changed the title
CGMossa
approved these changes
Jun 9, 2023
|
Thanks for approving. While there might be some better option to deal with the warning on oldrel, I believe this is better than doing nothing and let the CI keep failing. I'm merging this for now. |
dfalbel
added a commit
to extendr/helloextendr
that referenced
this pull request
Jun 29, 2023
As per: extendr/extendr#560
Ilia-Kosenkov
pushed a commit
to extendr/helloextendr
that referenced
this pull request
Jul 1, 2023
sorhawell
added a commit
to rpolars/extendr
that referenced
this pull request
Jul 9, 2023
This reverts commit 983fd58.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up of extendr/rextendr#285.