Make Rfloat, Rint, and friends ToVectorValue.
#593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright, except some more polish, I believe this is ready for review. Pinging @JosiahParry, @daniellga and @Ilia-Kosenkov for reviews / opinions. |
CGMossa
commented
Aug 25, 2023
JosiahParry
reviewed
Aug 25, 2023
|
@CGMossa thank you so much for making this PR! My naive eyes think its looks okay but im not even close to an expert here :P |
JosiahParry
reviewed
Aug 26, 2023
JosiahParry
reviewed
Aug 26, 2023
|
@CGMossa thanks for adding extra tests and comments! Looks good to my novice eyes! |
|
@CGMossa there's one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #592
This PR does two things:
Makes
Rints,&Rints,Rfloat, and&RfloatasToVectorValue, as these are wrapped Rust typesthat are safe to assume would translate to R. Moreover
Rbooland&Rboolwere alreadyToVectorValue,so it could have been a slight oversight
We are increasingly promoting
Integers,Logicals,Doubles, andComplexesas the better wayto extract vectors from R. Thus to make these more easier to work with, I've added
TryFrom<Vec<RustNative>>for all of them. This was previously accomplished withfrom_values,but I think these are intuitive interface for these as well.