Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extendr not thread-safe #674

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Conversation

CGMossa
Copy link
Member

@CGMossa CGMossa commented Nov 12, 2023

  • Remove all usage of single_threaded
  • Set --test-threads=1 always
  • No longer rely on ownership tracking across threads, i.e. use thread_local! for Ownership.

@CGMossa
Copy link
Member Author

CGMossa commented Nov 12, 2023

My issue on Windows, is that the CI already inserts an [env] in the .cargo/config.toml.

@CGMossa CGMossa marked this pull request as ready for review November 12, 2023 22:29
@CGMossa CGMossa marked this pull request as draft November 12, 2023 22:29
@CGMossa
Copy link
Member Author

CGMossa commented Nov 13, 2023

Dear @yutannihilation. This isn't ready for final review yet, but I do want your guidance on this PR.

Basically, I got fed up chasing my own tail, and really embedding unnecessary bottlenecks to extendr, without
really paying it off properly. So I thought a branch where we see how it would look without upfront promise
of thread-safety.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant