Update nonAPI.txt #227
Update nonAPI.txt #227
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
CGMossa
force-pushed
the
update_nonAPI_txt
branch
from
692844c
to
58587c8
Compare
|
@yutannihilation done! Can you review/approve? |
|
I can, but my approval is powerless. |
I'd appreciate it. A PR approved by you, is very valued. Regardless of the power to merge. |
|
Hm, okay. Then, let me hold my approval for a while. It seems they are actively messing the list of the "non-API"s. They put all the ALTREP-related APIs to the list. I'm wondering if they are sane... |
|
Could you update the non-API text again? It might keep updated, but I think it's good time. |
|
I saw your post on the R devel mailing list. Thanks for digging into this. |
|
Thanks, but my inquiry was just out of my own curiosity about ALTREP. Please jump in the discussion if you have opinions about API :) Note that, while they withdrew the changes about ALTREP, it seems they are serious about other ones. This is going to be tough... e.g. https://cran.r-project.org/web/checks/check_results_vctrs.html |
CGMossa
force-pushed
the
update_nonAPI_txt
branch
from
bdc897e
to
c79bb42
Compare
|
Status: We need to wait some more for this, as R-devel have an evolving discussion. Please ping us when the conversation has.. converged. |
Which one do you mean? If you are talking about this thread I started, there's no discussion related to the entry points deleted in this PR. https://stat.ethz.ch/pipermail/r-devel/2024-April/083339.html I'd recommend the extendr members to take these breaking changes seriously. It's fine not to merge this for now, but you should assess the impact of losing these APIs. |
CGMossa
force-pushed
the
update_nonAPI_txt
branch
from
81c8d53
to
96aaa30
Compare
|
Any update on this? |
|
Yes. I already have a PR that needs review and merging of the current changes to libr-Sys. Once that lands, I will immediately jump on this. The PR If you got any time and patience, I'd appreciate your review. It will help the extendr contributors approving my PR. |
Thanks. However, its content seems to be beyond my skills. |
Please review the diff and run /bindings command manually.