Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADDED SEXPTYPE in the altrep api #233

Merged
merged 10 commits into from Apr 27, 2024
Merged

ADDED SEXPTYPE in the altrep api #233

merged 10 commits into from Apr 27, 2024

Conversation

CGMossa
Copy link
Member

@CGMossa CGMossa commented Apr 27, 2024

Last adjustment before we may adopt libR-sys enums in extendr.

  • Non-exhaustive enum's are appearing as not FFI-safe
warning: `extern` fn uses type `libR_sys::Rboolean`, which is not FFI-safe
   --> extendr-api/src/wrapper/altrep.rs:845:23
    |
845 |                 narm: Rboolean,
    |                       ^^^^^^^^ not FFI-safe
    |
    = note: this enum is non-exhaustive

Of course, this may be an over-zealous linter, but I'm not capable of judging that myself. It seems pretty intensional.

  • The Coerce method has a second argument which is an Rboolean, but it isn't specifically written like that in the R-api. Therefore, we adopt a custom version of this.
    See Consider changing this Altrep-interface #232 for more context
    Please note that this coerce thing is not used, or tested, or exposed in the extendr's AltRep API. I don't know what we should do about that.

@CGMossa CGMossa merged commit ad5b628 into master Apr 27, 2024
@CGMossa CGMossa deleted the alrep_with_sexptype branch April 27, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants