Use Rtools43 #231
Merged
Use Rtools43 #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutannihilation
commented
Jan 17, 2023
|
Since it is a significant change, I suggest you mention this in the changelog. |
|
I see, thanks. |
Ilia-Kosenkov
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a part of extendr/extendr#442.
r-lib/actions now supports Rtools43 and uses it by default for R > 4.2 (c.f. r-lib/actions@740a0e7). So, this pull request removes the specification of
rtools-version: '42'on the R-devel runners.Also, this pull request stops relying on pkgbuild to detect
RTOOLS4x_HOMEfor R >=4.2. pkgbuild doesn't support Rtools43 yet, and all it does is just to checkRTOOLS4x_HOME(source code), so we can simply do the same thing.