-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new (experimental) function write_license_note
#271
Conversation
Now that the tests are working properly, I think you can merge this. |
This comment was marked as outdated.
This comment was marked as outdated.
Replacement by |
Will there be any benefit to storing license info in a |
Thanks for the review. I updated.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple of wording improvements here and there.
Co-authored-by: Ilia Kosenkov <ilia.kosenkov.at.gm@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well.. I of courses waited until @Ilia-Kosenkov did all the work. But atleast i've skimmed it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a singular typo. Otherwise looks lovely.
Close #236