Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added guard code to avoid NPE in assignCategory and assignAuthors functions #314

Closed
wants to merge 1 commit into from

Conversation

jitender94136
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #314 (e0a9607) into master (6d004b2) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #314      +/-   ##
============================================
- Coverage     78.10%   78.00%   -0.11%     
- Complexity      493      495       +2     
============================================
  Files            89       89              
  Lines          1544     1546       +2     
  Branches        128      128              
============================================
  Hits           1206     1206              
  Misses          269      269              
- Partials         69       71       +2     
Impacted Files Coverage Δ
.../java/com/aventstack/extentreports/ExtentTest.java 91.03% <0.00%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d004b2...e0a9607. Read the comment docs.

@anshooarora
Copy link
Member

Thank you for including this guardrail. Although, both can be used to the same effect, the following method is what has been used throughout this library. Can you please make this change and resend your PR?

x.trim().length() != 0

would be:

!x.trim().isEmpty()

@jitender94136 jitender94136 closed this by deleting the head repository Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants