This repository has been archived by the owner on May 1, 2021. It is now read-only.
standardize condition and remove phase #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moolen
added a commit
to external-secrets/external-secrets
that referenced
this pull request
Feb 6, 2021
moolen
added a commit
to external-secrets/external-secrets
that referenced
this pull request
Feb 6, 2021
see external-secrets/crd-spec#3 Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>
moolen
added a commit
to external-secrets/external-secrets
that referenced
this pull request
Feb 6, 2021
see external-secrets/crd-spec#3 Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor changes to the status of ExternalSecret and SecretStore.
status.refreshTimeto track last time the secret was fetched (needed by controller to remain stateless and implementspec.refreshInterval)status.phase, high level summary fields like phase should be generally avoided. If these additional states need to be tracked then a separate condition should be added.