feat: allow configuring GenServer timeout for requests #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdobacz
pushed a commit
to omgnetwork/elixir-omg
that referenced
this pull request
Sep 18, 2018
the only modification required is the request_timeout config PRed here: mana-ethereum/ethereumex#39
|
@pdobacz Can you bump version and add your changes to |
ayrat555
approved these changes
Sep 24, 2018
|
THank you @ayrat555 for looking into this. I was away, so sorry for the silence :) |
|
no worries. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the change is motivated by getting GenServer's timeouts when calling a slow geth instance. Now one can either configure the timeout on a
config.exslevel or pass the:request_timeoutkeyword argument to the request functions.