release: 1.0.0-rc2 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhelx
commented
Nov 21, 2023
| assert {:error, err_msg} = result | ||
| assert err_msg =~ ~r/Uncaught SyntaxError/ | ||
| end | ||
| # test "handles error on call" do |
There was a problem hiding this comment.
TODO: going to fix this in a follow up
bhelx
commented
Nov 21, 2023
| @@ -4,7 +4,7 @@ defmodule Extism.MixProject do | |||
| def project do | |||
| [ | |||
| app: :extism, | |||
| version: "1.0.0-rc1", | |||
| version: "1.0.0-rc2", | |||
There was a problem hiding this comment.
will bump to rc3 in a follow up
bhelx
commented
Nov 21, 2023
| } | ||
| // #[rustler::nif] | ||
| // fn set_log_file(file: String, log_level: String) -> Result<Atom, rustler::Error> { | ||
| // match extism::set_log_callback(logger, log_level) { |
There was a problem hiding this comment.
we need to refactor this to use set_log_callback. But, elixir callbacks aren't really a thing in rustler because you can't call erlang code from a NIF. so we'll need to come up with something more convoluted to handle this by using send to a PID that the user passes in and subcribes to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.