fix: Reinstantiate after call to _start
#135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zshipko
changed the title
_start
nilslice
changed the title
_start_start
zshipko
force-pushed
the
reinstantiate-after-start-call
branch
from
7e34a65
to
65cd7c1
Compare
… called multiple times
zshipko
force-pushed
the
reinstantiate-after-start-call
branch
from
65cd7c1
to
84a4cea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a closer reading of: https://github.com/WebAssembly/WASI/blob/main/legacy/application-abi.md it looks likes
_startis expected to be called at most once. This PR automatically reinstantiates a plugin after a call to_startso it can be used again.CI caught a bug with the
extism_versionoutput which is fixed here: #139