Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(haskell): cleanup haskell SDK to prepare for release #138

Merged
merged 27 commits into from
Dec 8, 2022
Merged

refactor(haskell): cleanup haskell SDK to prepare for release #138

merged 27 commits into from
Dec 8, 2022

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Dec 5, 2022 •
edited
Loading

  • Switches from stack to cabal
  • Cleanup SDK code
  • Adds release action (still waiting on Hackage upload approval)

@zshipko zshipko force-pushed the haskell-packaging branch 3 times, most recently from c045be3 to b85212a Compare December 6, 2022 22:33
@zshipko zshipko mentioned this pull request Dec 6, 2022
Merged
zshipko added a commit that referenced this pull request Dec 7, 2022
@zshipko
feat: Add support for allowed_paths manifest key in SDKs (#144)
acb06b9 
The Haskell SDK is updated here:
#138
@zshipko zshipko marked this pull request as ready for review December 7, 2022 23:09
nilslice
nilslice reviewed Dec 8, 2022
View reviewed changes
runtime/src/plugin.rs Outdated Show resolved Hide resolved
zshipko and others added 22 commits December 7, 2022 18:46
@zshipko
fix: add lower/upper bounds for base dependency
ab0de0f
@zshipko
cleanup: simplify examples, remove stack
1907994
@zshipko
ci: add release-haskell action
7d42bdb
@zshipko
fix: try different base version in cabal file
e78d94c
@zshipko
cleanup: lint
b817052
@zshipko
ci: fix haskell deps
0ab48d7
@zshipko
cleanup: format cabal file
3853b81
@zshipko
feat: add makefile for haskell
bfbbee6
@zshipko
cleanup(haskell): add comments, rename ErrorMessage to ExtismError, W…
4913b07 
…asmCode to WasmData and add Result type
@zshipko
feat: add allow_paths
a07b571
@zshipko
fix: generate bounds for dependencies
b874605
@zshipko
fix: adjust base bounds
4f7e143
@zshipko
fix: adjust base bounds
987024f
@zshipko
fix: create separate cabal file for extism-manifest package
9a49ceb
@zshipko
cleanup: use JSON class directly
f47705e
@zshipko
cleanup: more JSON improvements
1182cc6
@zshipko
fix: initialize haskell runtime
ed35b8a
@nilslice @zshipko
feat: improve checks in implicit runtime init/cleanup process
bc8c703
@nilslice @zshipko
fix: pass references to store
eea2e72
@zshipko
feat: add Runtime enum for handling runtime initialization/cleanup
ee1ad0c
@zshipko
cleanup: improve json API
eba0318
@zshipko
fix: extism-manifest.cabal
6589478
nilslice
nilslice reviewed Dec 8, 2022
View reviewed changes
runtime/src/plugin.rs Outdated Show resolved Hide resolved
nilslice
nilslice previously approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@nilslice nilslice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, @zshipko if you're on board with the updated message in the trace log, and CI passes - this LGTM!

@zshipko
Copy link
Contributor Author

zshipko commented Dec 8, 2022

Cool, I have a few more small changes I’ll push in the morning then I’ll merge it!

@zshipko zshipko merged commit e473d2c into main Dec 8, 2022
@zshipko zshipko deleted the haskell-packaging branch December 8, 2022 18:07
zshipko added a commit to extism/ocaml-sdk that referenced this pull request Sep 13, 2023
@zshipko
feat: Add support for allowed_paths manifest key in SDKs (#144)
12c6117 
The Haskell SDK is updated here:
extism/extism#138
zshipko added a commit to extism/cpp-sdk that referenced this pull request Sep 13, 2023
@zshipko
feat: Add support for allowed_paths manifest key in SDKs (#144)
b1f47ba 
The Haskell SDK is updated here:
extism/extism#138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilslice nilslice nilslice left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zshipko @nilslice