Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use timeouts for language-specific runtime initialization/finalization calls #169

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Dec 15, 2022

After adding the timer code plugins written in Haskell fail with a timeout when trying to call hs_init - this PR fixes the runtime initialization and updates those functions to respect the configured timeout.

@zshipko zshipko changed the title fix: runtime needs timer to initialize and cleanup language runtimes fix: use timeouts for runtime initialization/finalization calls Dec 15, 2022
@zshipko zshipko changed the title fix: use timeouts for runtime initialization/finalization calls fix: use timeouts for language-specific runtime initialization/finalization calls Dec 16, 2022
Copy link
Member

@nilslice nilslice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

@zshipko zshipko merged commit 34b5942 into main Dec 16, 2022
@zshipko zshipko deleted the init-runtime-timeout branch December 16, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants