fix(elixir): use local Rust extism package from extism_nif for local development
#180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bhelx
reviewed
Dec 20, 2022
| @@ -11,5 +11,5 @@ crate-type = ["cdylib"] | |||
|
|
|||
| [dependencies] | |||
| rustler = "0.26.0" | |||
| extism = { version = "0.1.0" } | |||
| extism = { version = "0.1.0", path = "../../../rust" } | |||
There was a problem hiding this comment.
I had to remove this for a reason. Can't quite remember why. I think it was failing on release. I'll test it out tomorrow.
There was a problem hiding this comment.
Thanks! Without this the changes from the local runtime crate aren’t be available, which tripped me up when I was testing something out.
There was a problem hiding this comment.
@bhelx - did you get a chance to test this out? just don't want to let it sit too long
There was a problem hiding this comment.
if i remember correctly, it was breaking on release. let me see if there is a way i can dry run it
There was a problem hiding this comment.
mix hex.publish --dry-run worked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.