feat: add ability to set host function namespace #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! This also reminds me we need to update the Runtime APIs page: https://extism.org/docs/concepts/runtime-apis And should probably have a similar page for Plugin APIs. Just a TODO for later. |
nilslice
reviewed
Feb 1, 2023
| C.extism_function_set_namespace(f.pointer, cstr) | ||
| } | ||
|
|
||
| func (f Function) WithNamespace(s string) Function { |
There was a problem hiding this comment.
does the method receiver here need to be a pointer type too? wonder or do you know if type checker will fail if its called on a non-pointer Function struct?
There was a problem hiding this comment.
I see, this is so it can be chained on NewFunction(...).WithNamespace(...).. makes sense
nilslice
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extism_function_set_namespaceto SDK