chore: update wasmtime to 6.0, bump extism versions #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! The issue with the extism_nif crate is in the release workflow. I'm not sure what the best way to toggle that path argument is, but for now it's helpful to make sure the new changes are working with the elixir sdk. |
zshipko
changed the title
zshipko
changed the title
zshipko
changed the title
|
@nilslice: just updated this to work with wasmtime 6.0.0, i think we can merge this once CI passes if you think the other changes on this branch are good to go |
|
the zig failure looks like its related to some language changes, i can update that in another PR |
@zshipko, yea I think you are right! sounds good to me |
|
I can't approve it though since I opened it initially. Please go ahead and do so at your convenience :) |
zshipko
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if now is the best time to do the
extismcrate version bumps, but I figured they'd need to happen at some point in the near future anyways. Happy to revert if there is any opposition. Also, I added back the localpathproperty to the Elixir NIF crate manifest. I want to see if this breaks again in CI, or if we can leave it.