Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: Bump runtime to 0.4.0 #340

Merged
merged 2 commits into from
May 19, 2023
Merged

release: Bump runtime to 0.4.0 #340

merged 2 commits into from
May 19, 2023

Conversation

bhelx
Copy link
Contributor

@bhelx bhelx commented May 10, 2023

Breaking Changes

HTTP calls will be disallowed by default now. If you want to enable HTTP you need to specify the hosts that the plug-in is allowed to communicate with. If you want to allow all hosts you can set it to {allowed_hosts: ["*"]} in the manifest. However, this isn't recommended unless you have some trust in the plug-in or are controlling the networking by some other means.

In this PR we are creating an implicit context so people don't need to know about it if they don't care. In some languages function signatures have changed to make context an optional argument when creating a plug-in.

@bhelx bhelx marked this pull request as ready for review May 18, 2023 15:26
@nilslice
Copy link
Member

With #315, I believe we will need to update docs around the default capabilities of the runtime & PDK code. It also obviates the need for the http feature, so maybe we should remove that?

@zshipko can probably shed more light here and help determine what needs to be kept/removed as far as features go.

@zshipko
Copy link
Contributor

zshipko commented May 18, 2023

the docs definitely need to be updated for the runtime and all the affected SDKs. we might want to keep the http feature though - compiling without it should result in a smaller runtime since ureq needs rustls and a bunch of other dependencies.

@bhelx
Copy link
Contributor Author

bhelx commented May 18, 2023

With #315, I believe we will need to update docs around the default capabilities of the runtime & PDK code. It also obviates the need for the http feature, so maybe we should remove that?

In general I wonder about compiler level features for the runtime. Most people experience it as a single shared binary. Asking them to compile it themselves without features seems like a lot. Although I could see someone really concerned about security dipping into that level when going to prod, just to make sure that a runtime / application level change couldn't open up a security hole.

Copy link
Member

@nilslice nilslice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bhelx bhelx merged commit d0f77dd into main May 19, 2023
32 checks passed
@bhelx bhelx deleted the release-0.4.0 branch May 19, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants