Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): use CString for strings passed to to set_log_file #341

Merged
merged 2 commits into from
May 12, 2023

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented May 11, 2023

No description provided.

@bhelx
Copy link
Contributor

bhelx commented May 12, 2023

This should work right?

// host
set_log_file("stdout", Some(log::Level::Trace));
// plugin
info!("Hello World!");

Still doesn't seem to be working for me

@zshipko
Copy link
Contributor Author

zshipko commented May 12, 2023

Does set_log_file return true or false?

@bhelx
Copy link
Contributor

bhelx commented May 12, 2023

It's returning false

@zshipko
Copy link
Contributor Author

zshipko commented May 12, 2023

thanks, i was able to replicate it and just pushed up a fix.

@bhelx
Copy link
Contributor

bhelx commented May 12, 2023

Works now!

@zshipko zshipko merged commit a0ec6a3 into main May 12, 2023
26 checks passed
@zshipko zshipko deleted the fix-set-log-level branch May 12, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants