Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(php): $err is not implicitly cast to string #344

Merged
merged 2 commits into from
May 15, 2023
Merged

fix(php): $err is not implicitly cast to string #344

merged 2 commits into from
May 15, 2023

Conversation

bhelx
Copy link
Contributor

@bhelx bhelx commented May 15, 2023

No description provided.

@bhelx bhelx marked this pull request as ready for review May 15, 2023 18:09
@bhelx bhelx requested a review from nilslice May 15, 2023 18:32
@nilslice
Copy link
Member

@bhelx LGTM, just added the same change in other places where a similar err concatenation is done... I think its fine?

nilslice
nilslice approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@nilslice nilslice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM save for the additions I made which you should review... the ol' review ally-oop! 🏀

@bhelx bhelx merged commit bb3902e into main May 15, 2023
3 checks passed
@bhelx bhelx deleted the fix-error-reporting-php branch May 15, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilslice nilslice nilslice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhelx @nilslice