Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use a range for wasmtime dependency version #375

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Jun 20, 2023

Currently wasmtime 8.0.0 - 10.0.0 are compatible with extism-runtime, in the interest of remaining compatible with as many applications as possible, this PR updates the wasmtime version requirement from a single version to a range of acceptable versions.

@@ -1,3 +1,5 @@
open Ppx_yojson_conv_lib.Yojson_conv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, CI failed without that

Copy link
Contributor

@bhelx bhelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go other than that one question.

@zshipko zshipko merged commit f606ab6 into main Jun 20, 2023
32 checks passed
@zshipko zshipko deleted the wasmtime-version-range branch June 20, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants