feat: Implement parts of the extism runtime in WebAssembly #384
Conversation
|
Could you add a README to the kernel project with a loose description of why it exists? Any graphs or art you have might help too. Either that or a top level module comment. |
…ut the kernel implementation
Good call! Just added a README: https://github.com/extism/extism/blob/fd783357547c5065284efaaa2755bb517ace7bfa/kernel/README.md and some more documentation to the implementation too: https://github.com/extism/extism/blob/fd783357547c5065284efaaa2755bb517ace7bfa/kernel/src/lib.rs |
| @@ -378,22 +401,22 @@ impl Plugin { | |||
| } | |||
|
|
|||
| pub(crate) fn initialize_runtime(&mut self) -> Result<(), Error> { | |||
There was a problem hiding this comment.
does this need to be done in kernel-based SDKs?
There was a problem hiding this comment.
For now yeah, that just makes it possible to side-step _start in modules that require initialization.
There was a problem hiding this comment.
Ok, good to know -- I think we need to include it in TODOs in the go-sdk cc/ @mhmd-azeez, unless its already being handled!
There was a problem hiding this comment.
I think we can use ModuleConfig.WithStartFunctions to do the same thing in wazero
There was a problem hiding this comment.
I added a TODO in the PR readme for it so that we don't forget it
| match res { | ||
| Ok(()) => (), | ||
| Err(e) => { | ||
| plugin.store.set_epoch_deadline(1); |
There was a problem hiding this comment.
figuring all of this is actually expected to remain here... I suppose this is at minimum related to the Rust SDK then, and possibly does need to be implemented in kernel-based SDKs?
There was a problem hiding this comment.
Yeah, timeouts and memory limits are features that will have to be implemented by each kernel-based SDK. This PR doesn't really change anything, but it does make it possible to start building up new SDKs that don't rely on this code anymore. Like in Go, cancellation suddenly becomes way easier because of Contexts, but in Rust it's kinds of a pain right now. If we decided to have an async runtime it would probably change the design a little bit - those are all things we should definitely explore!
|
Looks like I can't approve my own PR, but I'm merging this now! |
This PR adds the
kerneldirectory which contains a port of the Extism memory allocator compiled to WebAssembly and removesruntime/src/memory.rscompletely.Being able to re-use memory functions as a WASM module allows us to begin to experiment with porting Extism to new runtimes!
This is in a draft state while I'm verifying some of these changes.