Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(zig)!: Simplify JSON stringifying #414

Merged
merged 2 commits into from
Aug 12, 2023
Merged

refactor(zig)!: Simplify JSON stringifying #414

merged 2 commits into from
Aug 12, 2023

Conversation

usdogu
Copy link
Contributor

@usdogu usdogu commented Aug 11, 2023

Uses std.json.ArrayHashMap for stringifying.

Breaking Changes

  • Plugin.setConfig's config parameter's type changed to std.json.ArrayHashMap([]const u8)
  • WasmUrl's header field's type changed to std.json.ArrayHashMap([]const u8)
  • Manifest's config and allowed_path fields' types changed to std.json.ArrayHashMap([]const u8)

@zshipko
Copy link
Contributor

zshipko commented Aug 12, 2023

Looks great, thanks!

@zshipko zshipko merged commit 889ec39 into extism:main Aug 12, 2023
3 checks passed
@usdogu usdogu deleted the new-json-stringify branch August 12, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zshipko zshipko zshipko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@usdogu @zshipko