Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: build static libextism #552

Merged
merged 3 commits into from
Oct 27, 2023
Merged

feat: build static libextism #552

merged 3 commits into from
Oct 27, 2023

Conversation

G4Vi
Copy link
Contributor

@G4Vi G4Vi commented Oct 27, 2023 •
edited

  • libextism is now built to crate-type staticlib as recommend by @zshipko
  • updated Makefile to install and uninstall the static library.
  • updated c example to have static target to link libextism statically
    • Compiler is no longer hardcoded to clang. Set CC to use a compiler other than the system compiler. Tested with gcc and clang.
  • added static-artifact to actions release. Untested as it's only ran on push with tag.

@G4Vi G4Vi marked this pull request as ready for review October 27, 2023 22:09
zshipko
zshipko reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@zshipko zshipko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think the library name for windows is incorrect, but otherwise looks good.

I will update the CLI to install the static library too

.github/workflows/release.yml Outdated Show resolved Hide resolved
@G4Vi @zshipko
fix: extism msvc static lib name
067cc78 
Co-authored-by: zach <zach@dylibso.com>
@G4Vi G4Vi mentioned this pull request Oct 27, 2023
Closed
3 tasks
@G4Vi G4Vi requested a review from zshipko October 27, 2023 23:05
@G4Vi G4Vi merged commit fab44c5 into main Oct 27, 2023
31 checks passed
@G4Vi G4Vi deleted the static-libextism branch October 27, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zshipko zshipko zshipko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@G4Vi @zshipko