Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pkg-config #559

Merged
merged 2 commits into from
Nov 2, 2023
Merged

feat: pkg-config #559

merged 2 commits into from
Nov 2, 2023

Conversation

G4Vi
Copy link
Contributor

@G4Vi G4Vi commented Nov 2, 2023

Adds pkg-config configs for dynamic and static builds of libextism. Example usage is shown in libextism/Makefile.

I added the .skel versions of the .pc files to non-MSVC releases. Ideally, the extism cli when installing the lib would set the PREFIX and install them.

@G4Vi G4Vi requested a review from zshipko November 2, 2023 21:53
zshipko
zshipko previously approved these changes Nov 2, 2023
Copy link
Contributor

@zshipko zshipko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, it's a major improvement to be able to locate the installation!

Typically I have seen these files with the .pc.in extension but since they're renamed before getting copied it doesn't really matter either way.

@G4Vi
Copy link
Contributor Author

G4Vi commented Nov 2, 2023

Typically I have seen these files with the .pc.in extension but since they're renamed before getting copied it doesn't really matter either way.

I could not think of the convention in the moment. Fixed!

@G4Vi G4Vi requested a review from zshipko November 2, 2023 22:38
@G4Vi G4Vi merged commit 1aff1ce into main Nov 2, 2023
6 checks passed
@G4Vi G4Vi deleted the pkg-config branch November 2, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants