Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: allow Plugin::new to take raw wasm or Manifest #569

Merged
merged 3 commits into from
Nov 6, 2023
Merged

refactor!: allow Plugin::new to take raw wasm or Manifest #569

merged 3 commits into from
Nov 6, 2023

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Nov 6, 2023 •
edited

  • Removes Plugin::new_with_manifest and updates Plugin::new to take wasm bytes or Manifest using the new WasmInput trait
  • Removes PluginBuilder::new_with_module in favor of a PluginBuilder::new with a WasmInput argument

@zshipko zshipko force-pushed the remove-plugin-new-with-manifest branch from c35db75 to c8d22b0 Compare November 6, 2023 18:19
@zshipko zshipko changed the title cleanup: allow Plugin::new to take raw wasm or Manifest refactor!: allow Plugin::new to take raw wasm or Manifest Nov 6, 2023
@zshipko zshipko merged commit 3226060 into main Nov 6, 2023
6 checks passed
@zshipko zshipko deleted the remove-plugin-new-with-manifest branch November 6, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@zshipko