Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add x86_64-unknown-linux-musl target, specifying target to make #571

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

G4Vi
Copy link
Contributor

@G4Vi G4Vi commented Nov 6, 2023

The x86_64-unknown-linux-musl target does not build dynamic libraries for now:

 warning: dropping unsupported crate type `cdylib` for target `x86_64-unknown-linux-musl`

A target may now be optionally specified to the root Makefile, example:
make RUST_TARGET=x86_64-unknown-linux-musl && sudo make RUST_TARGET=x86_64-unknown-linux-musl install

The new musl targets may be used to create entirely static binaries with libextism. See the new musl-static target in libextism/Makefile

@G4Vi G4Vi requested a review from zshipko November 6, 2023 21:42
Copy link
Contributor

@zshipko zshipko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think the CLI is almost set up to handle this too, I need to take a look but I think we can just add a libc flag to specify which libc implementation/compiler to use.

@G4Vi
Copy link
Contributor Author

G4Vi commented Nov 6, 2023

I think the CLI is almost set up to handle this too, I need to take a look but I think we can just add a libc flag to specify which libc implementation/compiler to use.

Sounds good, maybe lib versions should list which triplets are available for the current system for each version.

@G4Vi G4Vi merged commit 9992d34 into main Nov 6, 2023
6 checks passed
@G4Vi G4Vi deleted the x86_64-musl branch November 6, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants