Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add add_subdirectory compatible cmake config #574

Merged
merged 1 commit into from
Nov 8, 2023
Merged

feat: add add_subdirectory compatible cmake config #574

merged 1 commit into from
Nov 8, 2023

Conversation

G4Vi
Copy link
Contributor

@G4Vi G4Vi commented Nov 8, 2023

This enables cmake in-tree builds with libextism such as with the cpp-sdk: extism/cpp-sdk#7

@G4Vi G4Vi requested a review from zshipko November 8, 2023 02:46
@G4Vi G4Vi changed the title feat: add add_subdirectory compatible cmake comfig feat: add add_subdirectory compatible cmake config Nov 8, 2023
zshipko
zshipko approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@zshipko zshipko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, tested and it works! I keep going back and forth on CMakeLists.txt in the root of the project vs in libextism but I think it makes sense like this since the documentation and everything is in that directory.

@G4Vi
Copy link
Contributor Author

G4Vi commented Nov 8, 2023

Nice, tested and it works! I keep going back and forth on CMakeLists.txt in the root of the project vs in libextism but I think it makes sense like this since the documentation and everything is in that directory.

It's worth considering. I avoided it as the root directory has a lot already and didn't want to create confusion with the root Makefile.

@G4Vi G4Vi merged commit 6e18283 into main Nov 8, 2023
6 checks passed
@G4Vi G4Vi deleted the libextism-cmake branch November 8, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zshipko zshipko zshipko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@G4Vi @zshipko