-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable wasmtime caching #605
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zshipko
changed the title
feat: support loading wasmtime compiled modules, enable wasmtime caching
feat: enable wasmtime caching
Nov 27, 2023
zshipko
force-pushed
the
wasmtime-caching
branch
from
November 27, 2023 20:16
cb6059b
to
d979e0d
Compare
mhmd-azeez
added a commit
to extism/go-sdk
that referenced
this pull request
Dec 5, 2023
This PR is related to extism/extism#605 ``` PS D:\dylibso\go-sdk> go test -benchmem -run=^$ -bench . goos: windows goarch: amd64 pkg: github.com/extism/go-sdk cpu: 13th Gen Intel(R) Core(TM) i7-1365U BenchmarkInitialize/noop-12 385 3051739 ns/op 2942236 B/op 2751 allocs/op BenchmarkInitializeWithCache/noop-12 2112 504269 ns/op 1686493 B/op 1554 allocs/op ``` Without using compilation cache: 3ms with compilation cache: 0.5ms Since we're already exposing `wazero.RuntimeConfig`, I think we just need to mention it in the README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate to: #596 without support for manually compiling/loading native code
EXTISM_CACHE_CONFIG
andPluginBuilder::with_cache_config
to determine where to load a custom cache configuration fromPluginBuilder::with_cache_disabled
to disable the cache when initializing a pluginEXTISM_CACHE_CONFIG=""
will also disable cachingPerformance
With caching:
Compared to
main
: