Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kernel): improve performance after large allocations, add extism_plugin_reset to give users more control when dealing with large allocations #627

Merged
merged 8 commits into from
Dec 12, 2023
Merged

fix(kernel): improve performance after large allocations, add extism_plugin_reset to give users more control when dealing with large allocations #627

merged 8 commits into from
Dec 12, 2023

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Dec 12, 2023 •
edited

See extism/cpp-sdk#15

  • Limits a call to memset in the kernel to the size of the current memory offset instead of the total size of memory.
  • Adds extism_plugin_reset to the C API and extism::Plugin::reset to Rust

@github-actions github-actions bot mentioned this pull request Dec 12, 2023
Merged
@github-actions @zshipko
update(kernel): extism-runtime.wasm in improve-performance-after-larg…
9576ef8 
…e-allocations (#628)

Automated PR to update `runtime/src/extism-runtime.wasm` in PR #627

Co-authored-by: zshipko <zshipko@users.noreply.github.com>
@zshipko zshipko mentioned this pull request Dec 12, 2023
Closed
@github-actions github-actions bot mentioned this pull request Dec 12, 2023
Merged
@github-actions @zshipko
update(kernel): extism-runtime.wasm in improve-performance-after-larg…
6beefe5 
…e-allocations (#629)

Automated PR to update `runtime/src/extism-runtime.wasm` in PR #627

Co-authored-by: zshipko <zshipko@users.noreply.github.com>
@zshipko zshipko changed the title fix(kernel): improve performance after large allocations fix(kernel): improve performance after large allocations, add extism_plugin_reset to give users more control when dealing with large allocations Dec 12, 2023
@github-actions github-actions bot mentioned this pull request Dec 12, 2023
Merged
@github-actions @zshipko
update(kernel): extism-runtime.wasm in improve-performance-after-larg…
1cae114 
…e-allocations (#630)

Automated PR to update `runtime/src/extism-runtime.wasm` in PR #627

Co-authored-by: zshipko <zshipko@users.noreply.github.com>
G4Vi
G4Vi approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@G4Vi G4Vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This makes performance much more predictable. I tested out extism_plugin_reset and that works as well.

@zshipko zshipko merged commit a5edf58 into main Dec 12, 2023
6 checks passed
@zshipko zshipko deleted the improve-performance-after-large-allocations branch December 12, 2023 21:56
This was referenced Dec 13, 2023
Merged
Merged
Merged
zshipko added a commit to extism/go-sdk that referenced this pull request Dec 13, 2023
@zshipko
chore: update extism-runtime.wasm (#48)
fd1af11 
See extism/extism#627
zshipko added a commit to extism/ocaml-sdk that referenced this pull request Dec 13, 2023
@zshipko
chore: add Plugin.reset (#13)
e6e67a7 
See extism/extism#627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G4Vi G4Vi G4Vi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zshipko @G4Vi