Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kernel): length function should return 0 for invalid offsets #635

Merged
merged 2 commits into from
Dec 15, 2023
Merged

fix(kernel): length function should return 0 for invalid offsets #635

merged 2 commits into from
Dec 15, 2023

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Dec 15, 2023

Fixes #634

  • Updates extism_length to walks the allocation list to determine valid offsets instead of assuming the provided offset is valid

@zshipko zshipko requested a review from G4Vi December 15, 2023 00:13
@github-actions github-actions bot mentioned this pull request Dec 15, 2023
Merged
@github-actions @zshipko
update(kernel): extism-runtime.wasm in fix-kernel-length (#636)
b1d162d 
Automated PR to update `runtime/src/extism-runtime.wasm` in PR #635

Co-authored-by: zshipko <zshipko@users.noreply.github.com>
@zshipko zshipko mentioned this pull request Dec 15, 2023
Closed
G4Vi
G4Vi approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@G4Vi G4Vi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out and it works great! Eventually, it may be worth exposing a block so iterating across the blocks isn't required to get the length, but I think this is a good idea for extism_length given the flexibility of an ExtismPointer.

@zshipko zshipko merged commit fd95729 into main Dec 15, 2023
6 checks passed
@zshipko zshipko deleted the fix-kernel-length branch December 15, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G4Vi G4Vi G4Vi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extism_length returns garbage values when an ExtismPointer is not aligned with an alloc
2 participants
@zshipko @G4Vi