Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kernel): add extism_length_unsafe #648

Merged
merged 2 commits into from
Jan 3, 2024
Merged

feat(kernel): add extism_length_unsafe #648

merged 2 commits into from
Jan 3, 2024

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Jan 3, 2024

  • Adds length_unsafe function to the extism kernel, a more performant length for known-valid memory handles

After this is merged I will update go-sdk and js-sdk too.

Closes #643

@zshipko zshipko requested a review from G4Vi January 3, 2024 16:53
Copy link
Contributor

@G4Vi G4Vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@zshipko zshipko merged commit 26542d5 into main Jan 3, 2024
5 of 6 checks passed
@zshipko zshipko deleted the length-unsafe branch January 3, 2024 17:29
zshipko added a commit to extism/go-sdk that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider reverting length safety improvement
2 participants