Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rust-protobuf support to extism-convert #653

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

nilslice
Copy link
Member

@nilslice nilslice commented Jan 5, 2024

(code from @zshipko, thank you!)

Co-authored-by: Zach Shipko <zach@dylibso.com>
@nilslice nilslice requested a review from zshipko January 5, 2024 22:52
@dselans
Copy link

dselans commented Jan 5, 2024

❤️

@zshipko
Copy link
Contributor

zshipko commented Jan 5, 2024

I think the CI failure is because when it's built with --all-features the two Protobuf types conflict

I'm wondering if we should just break the current feature names an use prost to enable the Prost type/prost crate and protobuf to enable the Protobuf type/protobuf crate. It seems like long-term that makes the most sense, even if it's kind of weird for current users right now.

@nilslice
Copy link
Member Author

nilslice commented Jan 5, 2024

I'm wondering if we should just break the current feature names an use prost to enable the Prost type/prost crate and protobuf to enable the Protobuf type/protobuf crate. It seems like long-term that makes the most sense, even if it's kind of weird for current users right now.

yea, I agree. I've updated to follow this plan.

@nilslice nilslice merged commit 211d553 into main Jan 5, 2024
5 checks passed
@nilslice nilslice deleted the rust-protobuf-convert branch January 5, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants