fix: use uint64 for Manifest.Timeout
#15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting
Manifest.Timeout
I got hung up because it is atime.Duration
value, so I was setting it totime.Milliseconds * time.Duration(3000)
instead of justtime.Duration(3000)
. This PR switchesManifest.Timeout
to be auint64
since it is already "timeout in milliseconds" - @mhmd-azeez if you think there's a better fix for this let me know!