Add plugin.CallWithContext method #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method allows calling plugin functions with a custom context.
|
Let me know if you want me to also document this method in the README or update any other docs. |
mhmd-azeez
requested changes
Mar 6, 2024
That'd be great! |
Marton6
force-pushed
the
feat/call-functions-with-custom-context
branch
from
b0a29d1
to
803d680
Compare
Added a note to the README! I didn't want to add a new section to not clutter the document too much as it is already quite lengthy. |
mhmd-azeez
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Looks great to me! I will just wait for @zshipko to take a look as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method that allows calling plugin functions with a custom context.
This will allow developers to call extism plugins with custom timeouts and cancellation.