WIP Configure Satis repository when enabling extension #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser, fixed tests, added travis
This makes it easier to re-use in other places of the extension
|
Didn't notice your I will try to merge all this in a single PR |
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=========================================
Coverage ? 31.73%
=========================================
Files ? 29
Lines ? 460
Branches ? 0
=========================================
Hits ? 146
Misses ? 314
Partials ? 0
Continue to review full report at Codecov.
|
luceos
approved these changes
Mar 24, 2017
|
Confirmed that this only works if "repositories" is an object, not an array, we have to mutate all items in that list to become an object (perhaps based on the path?) |
|
fixed the 403 by putting the token and Bearer witin single quotes |
This was referenced Apr 8, 2017
|
Going to add further logic in a new branch, let's move on with this. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not working at the moment, I'm getting 403 errors from the satis endpoint when enabled :(
Also, there's a quiet issue if a "repositories" key is present in composer.json but uses an array instead of an object (we need to name our repo so it can be easily found & replaced when enabling the extension)