Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

Stop forcing Ext.USE_NATIVE_JSON as false (use Ext JS default) #1605

Closed
fabriciomurta opened this issue Aug 6, 2018 · 1 comment
Closed

Comments

@fabriciomurta
Copy link
Contributor

Ext JS 6.6.0 has changed the setting to true, but it is incompatible with several parts of the code that takes advantage of the eval() nature of Ext JS's JSON implementation.

As it introduces a breaking change, and also will mean structural changes on Ext.NET direct method/events code, it should only follow to a major version release, so Ext.NET was set up to force using Ext JS implementation by default by #1604.

This change can only make it out to be a default in the v5 release of Ext.NET due to the breaking change nature.

The change here would be no longer force Ext.USE_NATIVE_JSON = false and use whatever Ext JS is set up to by default.

@fabriciomurta fabriciomurta added this to the 5.0 milestone Aug 6, 2018
@fabriciomurta fabriciomurta self-assigned this Aug 6, 2018
@fabriciomurta fabriciomurta changed the title Let Ext.USE_NATIVE_JSON be whatever Ext JS is Stop forcing Ext.USE_NATIVE_JSON as false (use Ext JS default) Aug 6, 2018
@fabriciomurta
Copy link
Contributor Author

With this, former calls from Ext.NET to Ext.decode() that were meant to be evaluated as javascript was changed to actual eval() calls, based on what Ext.decode() does when USE_NATIVE_JSON=false.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant