Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Language Client: Integrate diagnostic levels with existing errors #533

Closed
bryphe opened this issue Jul 12, 2017 · 1 comment
Closed

Language Client: Integrate diagnostic levels with existing errors #533

bryphe opened this issue Jul 12, 2017 · 1 comment
Assignees
Milestone

Comments

@bryphe
Copy link
Member

bryphe commented Jul 12, 2017

  • Leverage the DiagnosticSeverity as documented in the language server protocol. This is important as the OCaml/Reason language service leverages this.
@bryphe bryphe self-assigned this Jul 12, 2017
@bryphe bryphe added this to the 0.2.7 milestone Jul 12, 2017
bryphe pushed a commit that referenced this issue Jul 19, 2017
* Start refactoring interface to use diagnostic type

* Continue working with types.Diagnostic

* Refactor to use types.Diagnostic

* Update types

* Bring back setErrors call

* Restore ErrorOverlay functionality

* Fix error messages

* Restore error / warning behavior

* Add SetErrorsAction/ClearErrotsAction

* Add error info to state

* Add action creators for set / clear errors

* Hook up react store to provider

* Add reselect

* Reformat to use store data instead of separate array of errors

* Fix selector

* Add reducer to handle errors

* Add window state to redux store

* Create actions for window state

* Add reducer for window actions

* Set up windowState and hook up reducer to top-level reducer

* Add ActiveWindow component

* Test out ActiveWindowContainer

* Remove background color

* Create new, side-by-side implementation of WindowContext to support refactoring. WindowContext2 will replace WindowContext once the refactoring is complete.

* Remove ErrorOverlay, refactor to use store state completely

* Fix some runtime errors

* Fix path normalization and preserve existing errors

* Add windowTopLine/windowBottomLine to redux store, and move more state over to the connected component

* Add error markers

* Add cursor and errors back in

* Remove ScrollBarOverlay

* Add SET_BUFFER_STATE action

* Wire up total buffer lines

* Remove error test in NeovimInstance

* Remove legacy SetActiveWindowDimensions action

* Refactor ActiveWindow to separate file

* Fix issue with empty string buffer name

* Show details only when not in insert mode

* Fix regerssion with cursorLine

* Add PLAN, fix compile errors after merge

* Fix lint issues

* Remove PLAN.md

* Update failing unit tests
@bryphe
Copy link
Member Author

bryphe commented Jul 23, 2017

Fixed by #534

@bryphe bryphe closed this as completed Jul 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant