Skip to content
This repository has been archived by the owner on Apr 1, 2020. It is now read-only.

Integrate OCaml/ReasonML language server #389

Open
bryphe opened this issue Apr 19, 2017 · 5 comments
Open

Integrate OCaml/ReasonML language server #389

bryphe opened this issue Apr 19, 2017 · 5 comments
Milestone

Comments

@bryphe
Copy link
Member

bryphe commented Apr 19, 2017

Language server here: https://github.com/freebroccolo/ocaml-language-server

Wanted an excuse to learn more about these languages 馃憤 馃憤

@bryphe bryphe added this to the 0.4 milestone Apr 19, 2017
@bryphe bryphe changed the title Add OCaml/ReasonML support Integrate OCaml/ReasonML language server Apr 19, 2017
@jordwalke
Copy link

In the ReasonML Discord channel, we consistently hear overwhelmingly positive feedback about @freebroccolo's VSCode plugin and language server.

@bryphe bryphe modified the milestones: 0.3, 0.4 Apr 26, 2017
@bryphe bryphe modified the milestones: 0.2.5, 0.3 May 22, 2017
@keforbes keforbes modified the milestones: 0.3, 0.2.5 Jun 15, 2017
@keforbes
Copy link
Collaborator

Moving back to 0.3 since 0.2.5 was released without this getting merged in, #488. 馃槢

@bryphe
Copy link
Member Author

bryphe commented Jul 13, 2017

Merged in the ocaml-language-server integration, since that was blowing up (and most of it was really not specific to ocaml/reason, but just extending out the language server protocol support - since ocaml-language-server is the most complete implementation I've used so far).

A few remaining items I'd like to look at before closing this:

There are also some longer-term items I'd like to look at, potentially outside the scope of this item, like:

  • Integrated playground (this helped me a lot testing out reason & ocaml + bucklescript)
  • Moving some other Oni components to Reason, including some UI components. (For example, modularing out the QuickOpen experience and implementing as a reason-based plugin). I'd like for Oni to have a first-class Reason experience, on-par or beyond the TypeScript support.

@bryphe bryphe modified the milestones: 0.3, 0.4 Mar 2, 2018
@dvisztempacct
Copy link

Hi.

My team and I are trying to flesh out our tooling for ReasonML development.

We've used vim, neovim, atom, vscode, and now oni!

I wanted to take a crack at integrating ocaml-language-server formatting for Oni, but since I saw this issue has been open for a while, I thought I'd ask here what's holding it up, or if you have any specific idea about what a good or bad approach might be.

I've had some experience hacking on the same integration for nvim using languageclient-neovim and ocaml-language-server, but from skimming through Oni's source code it seems like you guys are into vscode-languageclient, and maybe that has something to do with the slow movement here?

Let me know!

@akinsho
Copy link
Member

akinsho commented Apr 18, 2018

@dvisztempacct I think the main hurdle here is that there are quite a few bits of LSP functionality that our ls client doesn't handle yet like formatting, code actions etc. I don't think the vscode client is a particular hurdle (@bryphe) can answer this best but I think it's just an outstanding bit of work which @bryphe started to look at in #974 and #1326 so if you were curious about looking at that I think those PR's would be a good place to start

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants