1.6.31 breaks parsing wikipedia articles #41
Comments
|
@davidcameron thanks. I will take a look on this case. |
ndaidong
added a commit
that referenced
this issue
Jun 13, 2017
Merged
|
@davidcameron A script to handle Wikipedia link has been added to v1.6.4, please check if it works for you now. |
|
This still doesn't seem to work for me, running v1.6.4: var fetch = require('node-fetch');
var parser = require('article-parser');
var fs = require('fs');
var articleUrl = 'https://en.wikipedia.org/wiki/Ramen';
fetch(articleUrl)
.then(res => {
return res.text();
})
.then(html => {
//console.log('html', html);
parser.getArticle(html).then(stuff => {
console.log('done', stuff);
fs.writeFile('./ramen.html', stuff, function (e) {
e && console.log('file error', e);
});
});
});^ Logs and writes an empty response. |
|
@davidcameron I think it was resolved with v2.0.0-rc I've just released. Please help me test if it works. Thanks. |
|
@davidcameron : after a week of testing, it looks like the problem has been resolved as well by v2.x.x, so I would close this issue now. Feel free to reopen if it still not works for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I get nothing back when calling
.getArticleon a Wikipedia article (try https://en.wikipedia.org/wiki/Ramen).1.6.2 returns
<head>tags for Wikipedia articles. 1.6.15 works correctly with Wikipedia articles.The text was updated successfully, but these errors were encountered: