Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong TS type without normalization. #115

Closed
sharifzadesina opened this issue Oct 9, 2023 · 1 comment
Closed

Wrong TS type without normalization. #115

sharifzadesina opened this issue Oct 9, 2023 · 1 comment

Comments

@sharifzadesina
Copy link

When normalization option is false the returned type FeedData is false.

I suggest we return a generic type like Record<string, any>.

@olsonpm
Copy link
Contributor

olsonpm commented Dec 9, 2023

@sharifzadesina I'm not great with typescript - do you have a suggestion on how to implement that in a type definition file rather than in typescript code ?

Seems to me the best way to implement this request would be to have separate functions since you can't always infer the runtime options type. e.g. extractRaw => Record<string, any>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants