Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The link cannot be resolved when the hostname is not included #89

Closed
kahosan opened this issue Jun 5, 2023 · 0 comments · Fixed by #90
Closed

The link cannot be resolved when the hostname is not included #89

kahosan opened this issue Jun 5, 2023 · 0 comments · Fixed by #90

Comments

@kahosan
Copy link
Contributor

kahosan commented Jun 5, 2023

example:

<channel>
  <link>/</link>
  <language>en</language>
  <atom:link href="/index.xml" rel="self" type="application/rss+xml" />
  <item>
    <link>/posts/2023/06/piem/</link>
	<guid>/posts/2023/06/piem/</guid>
  </item>
</channel>

When the link is in the above format, it will be resolved as null:

{
  "link": null,
  "language": "en",
  "atom:link": {
    "@_href": "/index.xml",
    "@_rel": "self",
    "@_type": "application/rss+xml"
  },
  "item": [
    {
      "link": null,
      "guid": "/posts/2023/06/piem/"
    }
  ]
}
kahosan added a commit to kahosan/feed-extractor that referenced this issue Jun 12, 2023
ndaidong added a commit that referenced this issue Jun 14, 2023
fix: link cannot be resolved #89
ndaidong added a commit that referenced this issue Jun 14, 2023
- Merge pr #90 by @kahosan
- Update dependencies

Related issues: #89
@ndaidong ndaidong mentioned this issue Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant