Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep commit message when pre-commit hook fails #1035

Closed
aouaki opened this issue Dec 9, 2021 · 2 comments · Fixed by #1036
Closed

Keep commit message when pre-commit hook fails #1035

aouaki opened this issue Dec 9, 2021 · 2 comments · Fixed by #1036
Labels
enhancement New feature or request
Milestone

Comments

@aouaki
Copy link

aouaki commented Dec 9, 2021

Is your feature request related to a problem? Please describe.
I'm always frustrated when my pre-commit fails, because the commit message I wrote in gitui gets lost. When I fix the issue and want to commit again, I have to write the commit message from scratch (I sometimes need a few attempts, that's very frustrating...)

Describe the solution you'd like
To me, the commit message I had written when the pre-commit failed should be pre-filled when trying to commit again.

Additional context
I'm using pre-commit for the hook, and gitui 0.18.0

Thanks!

@extrawurst
Copy link
Owner

Hey @aouaki thanks for reaching out. that makes sense. there is: #937 which should solve this but no one took the time yet.

@extrawurst extrawurst added this to the v0.20 milestone Dec 9, 2021
@extrawurst extrawurst added the enhancement New feature or request label Dec 9, 2021
extrawurst pushed a commit that referenced this issue Dec 9, 2021
@extrawurst
Copy link
Owner

ok without the complexity of history and stuff just preserving the current msg if the commit fails was a rather low hanging fruit, so thats done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants