Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search branch #1350

Closed
Wyfy0107 opened this issue Sep 21, 2022 · 6 comments
Closed

Search branch #1350

Wyfy0107 opened this issue Sep 21, 2022 · 6 comments
Milestone

Comments

@Wyfy0107
Copy link

Is your feature request related to a problem? Please describe.
When viewing all the branches in gitui, I would like to have the ability to search through these branches

Describe the solution you'd like
Perhaps in the branch view, press / to start searching, similar to vim

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@extrawurst
Copy link
Owner

would be nice to reuse the fuzzy search popup we have for this already (see the file tab)

@Wyfy0107
Copy link
Author

Haven't used rust yet, but can I try to add this feature ?

@Wyfy0107
Copy link
Author

I won't be able to work on this issue. Please feel free to take over

@ObiWanRohan
Copy link

I'm trying my hand at this.

@ObiWanRohan
Copy link

@extrawurst I have added a key ("Branch Find Toggle") which would toggle the focus to the find box in the branch list popup.
Pressing the key (Currently / by default) would shift the focus to the text input.
I didn't go the route of making it similar to the file finder, as there are no other possible inputs in the file finder. Here there are possible inputs like c for create branch, r for rename and so on.
Otherwise there would have to be a completely separate finder popup for the branches (this is also an option).

Some feature questions come to mind:

  • What should be the scope of the finder? (Just the open tab or both tabs). The open tab is easier to implement as it needs lesser changes.
  • Should the matches be highlighted or should only the matches be shown?
  • How does the user exit the find mode? (The Escape key or backspacing the whole input)

I'll add more as they come.

@ObiWanRohan
Copy link

@extrawurst Pinging for answers

@extrawurst extrawurst added this to the v0.23 milestone Apr 19, 2023
extrawurst added a commit that referenced this issue Apr 22, 2023
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this issue Jun 4, 2024
* add branch_find_popup
* capital F for fetch in branchlist, f for find
* add command info of return

closes extrawurst#1350
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this issue Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants