Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some colors inverted on highlight, not all. #1365

Closed
gb-papercut opened this issue Sep 30, 2022 · 1 comment · Fixed by #1366
Closed

Some colors inverted on highlight, not all. #1365

gb-papercut opened this issue Sep 30, 2022 · 1 comment · Fixed by #1366
Labels
enhancement New feature or request
Milestone

Comments

@gb-papercut
Copy link

Thanks for gitui! Wow, so many years of using git from the CLI because I could never find a UI that I liked. Great work.

I noticed some colours get inverted on selection highlight. For example, the default black text turns to white:

image

Others, don't get inverted, like this one:

image

This makes it difficult to pick a selection_bg that works for all cases.

Both iTerm2 and Terminal on macos display this behavior.

@gb-papercut
Copy link
Author

gb-papercut commented Sep 30, 2022

This issue talks about setting the colors in iTerm2's theme to get everything right, but I think that's a bit different than my issue of "sometimes inverting" selections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants