commit messages in the log page are sometimes missing #1473
Labels
bug
Something isn't working
Comments
|
@extrawurst nevermind, after more debugging I think it's unrelated to fetch / needs data. I think the issue only happens with repos with small number of commits. adding some logs to see what's going on. |
kting28
added a commit
to kting28/gitui
that referenced
this issue
Feb 27, 2023
When sync::get_commits_inf is called in revlog:::fetch_commits, the message limit used was the length of the list which can be zero at start up before items are fetched. This results in initial view of the Log view showing empty messages.
kting28
added a commit
to kting28/gitui
that referenced
this issue
Mar 1, 2023
When sync::get_commits_inf is called in revlog:::fetch_commits, the message limit used was the length of the list which can be zero at start up before items are fetched. This results in initial view of the Log view showing empty messages.
|
see #1566 |
4 tasks
extrawurst
added a commit
that referenced
this issue
Mar 1, 2023
sometimes messages appear empty because getting the revlog is so fast (empty repo) that no draw happened yet and so we do not know yet what size the view will have. fixes #1473
extrawurst
added a commit
that referenced
this issue
Mar 1, 2023
sometimes messages appear empty because getting the revlog is so fast (empty repo) that no draw happened yet and so we do not know yet what size the view will have. fixes #1473
This was referenced Mar 15, 2023
IndianBoy42
pushed a commit
to IndianBoy42/gitui
that referenced
this issue
Jun 4, 2024
sometimes messages appear empty because getting the revlog is so fast (empty repo) that no draw happened yet and so we do not know yet what size the view will have. fixes extrawurst#1473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Sometimes the commit messages are missing, see video below
To Reproduce
the steps to reproduce the error could not be clearly determined.
On some repos it functions correctly (showing the commit messages), on other repos it does not. The reason is not clear.
Log[2]overview page notice the missing "commit messages"2the messages show up correctlyExpected behavior
The commit message should always show up.
Screenshots
The video first checks the commit messages on the meiji163/gh-notify repo and then on extrawurst/gitui repo.
fspeedOUTPUT.12.mp4
Context (please complete the following information):
macOS 10.15(reproducible with defaultTerminalandiTerm2)0.22.1stable 1.65.0 (bottled)(installed via Homebrew)Additional context
I tried to bisect the issue, but I ended up with the commit 9534e4c, that introduced the feature to save the last page the user viewed.
The problem may have been there for a while, but I never noticed it because I always had to press the
2key to see the log page.PS: Great tool you have made.
The text was updated successfully, but these errors were encountered: