Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display non-UTF8 commit messages at least partially #150

Closed
Boddlnagg opened this issue Jun 24, 2020 · 4 comments
Closed

Display non-UTF8 commit messages at least partially #150

Boddlnagg opened this issue Jun 24, 2020 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@Boddlnagg
Copy link

Describe the bug
Currently when a commit message contains invalid UTF8, the whole message is replaced by the string <unknown>.

To Reproduce
Create a Git commit with a message that contains invalid UTF8.

Expected behavior
I think it would be more useful to use replacement characters (i.e. lossy decoding), so at least most of the commit message is displayed correctly if it only contains a single non-UTF8 character somewhere.

@extrawurst extrawurst added the bug Something isn't working label Jun 24, 2020
@extrawurst extrawurst added this to the v0.8 milestone Jun 24, 2020
@extrawurst
Copy link
Owner

@Boddlnagg thanks for reporting this, good point! It should be fixed now, but you have no idea how hard it was to force invalid utf8 down rusts safe throat. even the git shell fixed up broken utf8 commit message files. If you could build and test gitui on master to make sure your repro cases are fixed would be awesome!

@Boddlnagg
Copy link
Author

Yes, it works now! Thanks for the quick fix 👍

@extrawurst
Copy link
Owner

Great! @Boddlnagg thanks for checking!

@extrawurst
Copy link
Owner

released in 0.8 now: https://github.com/extrawurst/gitui/releases/tag/v0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants